0000849: Smart LowId never worked

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000849

aMule

Servers

public

2006-03-21 15:21

2006-05-24 03:55

Reporter

eyalzo

Assigned To

Kry

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

2.1.1

Target Version

Fixed in Version

SVN

Summary

0000849: Smart LowId never worked

Description

I tested this very-old feature, and found that it does not work. Using iptables I blocked my TCP port, and found that it always connects with low-id to the first or second server.

Additional Information

Looking at eMule and aMule 2.1.1, I saw that it has never been changed. That's strange. People are talking about this feature all over.
Maybe I missed something?
Anyway, here is the simple fix. Seems like someone forgot to set the state to 1 before trying to connect a new server. This is why this feature does not work when starting aMule.
The fix:

void CServerConnect::ConnectToServer(CServer* server, bool multiconnect)
{
...
    //eyal 21-03-2006: fix smart-lowid
    if(thePrefs::GetSmartIdCheck())
    {
        thePrefs::SetSmartIdState(1);
    }

    newsocket->ConnectToServer(server);
...
}

Tags

No tags attached.

Fixed in Revision

Operating System

Attached Files

Relationships

Notes
(0002000) Kry (manager) 2006-05-24 03:55	Commited.

Issue History
Date Modified	Username	Field	Change
2006-03-21 15:21	eyalzo	New Issue
2006-03-22 20:43	Kry	Status	new => assigned
2006-03-22 20:43	Kry	Assigned To	=> Kry
2006-05-24 03:55	Kry	Status	assigned => resolved
2006-05-24 03:55	Kry	Fixed in Version	=> CVS
2006-05-24 03:55	Kry	Resolution	open => fixed
2006-05-24 03:55	Kry	Note Added: 0002000